Skip to content
This repository was archived by the owner on Jun 11, 2021. It is now read-only.

[google_sign_in_dart] Null safety migration#29

Open
GroovinChip wants to merge 18 commits into
long1eu:developfrom
GroovinChip:null_safety
Open

[google_sign_in_dart] Null safety migration#29
GroovinChip wants to merge 18 commits into
long1eu:developfrom
GroovinChip:null_safety

Conversation

@GroovinChip

@GroovinChip GroovinChip commented Apr 10, 2021

Copy link
Copy Markdown
  • Fix example not having a Dart SDK lower bound constraint
  • Updates all dependencies to latest resolvable null-safe versions
  • Migrate deprecated buttons in example
  • Regenerate macOS podfile
  • Migrate package and example code to null safety
  • Bump package version to 0.0.9

@long1eu I would appreciate a review on this please.

@GroovinChip GroovinChip changed the base branch from master to develop April 10, 2021 19:12
@GroovinChip

Copy link
Copy Markdown
Author

Update target branch to dev per request

@GroovinChip

Copy link
Copy Markdown
Author

@long1eu Have you had a chance to review this yet?

@long1eu long1eu self-requested a review May 15, 2021 05:41

@kevinlinnebur kevinlinnebur left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far

```dart
Future<void> main() async {
if (isDesktop) {
GoogleSignInPlatform.register(clientId: <clientId>);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@guyluz11

Copy link
Copy Markdown

The pull request will solve issue #28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants